Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release fix for endless loop when slider is empty #471

Open
jjeising opened this issue Mar 29, 2020 · 2 comments
Open

Release fix for endless loop when slider is empty #471

jjeising opened this issue Mar 29, 2020 · 2 comments

Comments

@jjeising
Copy link

While #232 was fixed in clones.js#L25 again with #355 on Jul 22, 2019 the fix is not included in dist/ in the latest release (3.4.1) from Sep 23, 2019:

/*!
 * Glide.js v3.4.1
[…]
*/
[]
    collect: function collect() {
[]
      var end = slides.slice(-part);

      for (var r = 0; r < Math.max(1, Math.floor(perView / slides.length)); r++) {

Could you please create a new release with the fix included?

@simplenotezy
Copy link

This is VERY much needed. The freeze does not happen all the time, but it happens, and when it happens, Chrome is totally unresponsive. Is Glide.js still being maintained?

@simplenotezy
Copy link

@jedrzejchalubek Do you need helpers who could maintain this repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants