Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setTimeout used instead of requestAnimationFrame #655

Open
davidstellini opened this issue Mar 22, 2023 · 1 comment
Open

setTimeout used instead of requestAnimationFrame #655

davidstellini opened this issue Mar 22, 2023 · 1 comment

Comments

@davidstellini
Copy link

I was looking at a burndown chart and saw the carousel was responsible for a large chunk of JS execution time:
image

When looking at the culprit, it seems like most of the time is spent here:

I searched the repo for requestAnimationFrame and didn't find anything, could you kindly confirm if this is a problem or not? I can open a pull request for it.

@jedrzejchalubek
Copy link
Member

jedrzejchalubek commented Mar 25, 2023

Yeah, basing this on requestAnimationFrame would be much better. setTimeout lacks performance and precision here. Would love to see MR that migrates to that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants