Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple commands is not supported in Procfile #326

Closed
jxltom opened this issue Feb 5, 2018 · 7 comments
Closed

Multiple commands is not supported in Procfile #326

jxltom opened this issue Feb 5, 2018 · 7 comments
Labels

Comments

@jxltom
Copy link

jxltom commented Feb 5, 2018

command_a; command_b or command_a && command_b format command in Procfile is not supported.

This is because eval echo "$@ in exec setuidgid "$unprivileged_user" $(eval echo "$@")

exec setuidgid "$unprivileged_user" $(eval echo "$@")
will strip the multiple commands

@jxltom
Copy link
Author

jxltom commented Feb 11, 2018

Currently I can only run multiple command by web $(command_a; command_b)

@michaelshobbs
Copy link
Member

That is correct. I also use a Makefile to achieve executing multiple commands where absolutely necessary.

@jxltom
Copy link
Author

jxltom commented Feb 13, 2018

@michaelshobbs But in heroku, web: command_a; command_b is supported. Why not herokuish support multiple commands like that? Considering herokuish is trying to emulating heroku, it will be nice to have same behaviour.

@josegonzalez
Copy link
Member

Because its hard to do it and not a common pattern. I would actually say that such a Procfile is wrong, but since there isn't a Procfile standard out there, shrug.

If you would like to submit a pull request to change this (with tests!) feel more than free to do so. I'd be happy to review :)

@jxltom
Copy link
Author

jxltom commented Feb 13, 2018

@josegonzalez

OK. Thanks for clarifying my doubt.

@ghost
Copy link

ghost commented Dec 23, 2019

I'd like to note with the backref above, that this is expected behavior in a lot of apps targeting heroku out of the box, like for instance https://github.com/tootsuite/mastodon

@josegonzalez
Copy link
Member

If you'd like to make a pull request implementing this functionality, that would be great. Otherwise, I don't think it's worth the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants