Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error message when custom buildpack download fails #553

Open
jarthod opened this issue Apr 5, 2020 · 0 comments
Open

No error message when custom buildpack download fails #553

jarthod opened this issue Apr 5, 2020 · 0 comments

Comments

@jarthod
Copy link

jarthod commented Apr 5, 2020

When passing an invalid buildpack URL like a simple string "ruby", the download fails without any error or explanation, when building it finishes like this:

> dokku buildpacks:add suzaku ruby
> dokku buildpacks:list suzaku
-----> suzaku buildpack urls
       ruby
> dokku ps:rebuild suzaku
-----> Cleaning up...
-----> Building suzaku from herokuish...
-----> Adding BUILD_ENV to build environment...
-----> Warning: Multiple default buildpacks reported the ability to handle this app. The first buildpack in the list below will be used.
       Detected buildpacks: multi ruby
-----> Multipack app detected
=====> Downloading Buildpack: ruby

→ the output stops here without any error, it's not even clear it failed in this case.

I also made one ticket about validating the buildpack URL: dokku/dokku#3923
But even so some error handling need to be implemented here as the download could fail for other reasons not possible to validate when adding the URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant