Skip to content
This repository has been archived by the owner on Mar 5, 2018. It is now read-only.

Things That Need To Be Fixed #54

Closed
8 tasks
chadhietala opened this issue Apr 9, 2017 · 3 comments
Closed
8 tasks

Things That Need To Be Fixed #54

chadhietala opened this issue Apr 9, 2017 · 3 comments

Comments

@chadhietala
Copy link
Member

chadhietala commented Apr 9, 2017

This is an ongoing list of stuff that I'm finding that have discovered in trying to work on this.

Build

  • No confidence in types at build/publish time
  • Build seems pretty slow for the amount of files
  • Extract GlimmerTemplateCompiler
  • le sourcemaps

Test Suite

  • Test suite should have more exhaustive rendering tests, similar to Ember's
  • ember serve should run the tests
  • Unclear how to test end-to-end typical application with Component and @tracked
  • Tests don't update
@pittst3r
Copy link
Contributor

pittst3r commented Apr 9, 2017

Re: extracting GlimmerTemplateCompiler. I believe I spoke to someone about moving that upstream into @glimmer/compiler after making it more generic. For example, specifier generation is hard-coded right now.

@pittst3r
Copy link
Contributor

pittst3r commented Apr 9, 2017

Also, some rendering tests are WIP in #40.

@locks
Copy link
Contributor

locks commented Mar 5, 2018

This repo has been merged with glimmerjs/glimmer.js (into a monorepo setup). I am not sure if this issue is still applicable, but if you could confirm it is still an ongoing concern and open it over there that would be very helpful.

Sorry for the noise, but thank you for your help!

@locks locks closed this as completed Mar 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants