Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License metadata for v0.85 packages is missing #1463

Closed
davidtaylorhq opened this issue Oct 25, 2023 · 4 comments · Fixed by #1579
Closed

License metadata for v0.85 packages is missing #1463

davidtaylorhq opened this issue Oct 25, 2023 · 4 comments · Fixed by #1579

Comments

@davidtaylorhq
Copy link

We use licensee to check license compatibility of all our dependencies in Discourse. The recent 0.85 version bump of glimmer packages is causing licensee checks to fail on @glimmer/syntax and @glimmer/interfaces because it is unable to find valid version Metadata.

This is also evident on NPM, where v0.84.3 correctly shows "License: MIT", while v0.85.3 shows "License: none".

I'm not sure what has changed here. It doesn't look like the 0.84.3 package.json files had a license key either... so something (related to the release process?) must have been magically inserting the license metadata in the past. 🤔

@NullVoxPopuli
Copy link
Contributor

NullVoxPopuli commented Oct 25, 2023

Thanks for opening this issue! The vm repo has had a toooon of infra changes since 0.84.3, so that's probably an explanation..

Will fix, thanks!

@andreyfel
Copy link
Contributor

Experiencing the same issue. Maybe an easy fix for that could be to add a license field to all packages' package.json files?

@NullVoxPopuli
Copy link
Contributor

sounds reasonable to me! sorry I haven't gotten to this. doing too many things 😅

@andreyfel
Copy link
Contributor

#1579

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants