Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address feedback sent in #27

Closed
2 of 5 tasks
acorncom opened this issue Mar 28, 2017 · 7 comments
Closed
2 of 5 tasks

Address feedback sent in #27

acorncom opened this issue Mar 28, 2017 · 7 comments

Comments

@acorncom
Copy link
Member

acorncom commented Mar 28, 2017

There was a good and thoughtful issue opened at glimmerjs/glimmer-component#29 that has some good suggestions we should address:

  • UI components for what? Visitors should get this clear immediately
  • "Attention to detail of ember" - is that a quality comparison, or is it only for ember framework?
  • UI projects should have at least one or two screenshots
    Should mention at least one actual feature or component
  • GitHub link doesn't go to a repo. Instead it's a list of repos that you have to click around in to find the main project.
  • API docs link goes to a page that is blank except for another link to the actual API docs. If docs are not ready better to just link to "#", avoid frustration
@tomdale
Copy link
Collaborator

tomdale commented Mar 29, 2017

This is great feedback! I agree with many of these points. I think there is maybe a little bit of confusion embedded in this feedback (which is itself helpful!). It sounds like we're coming across as a library of UI components instead of a library for building your own UI components, i.e., Bootstrap instead of React.

Other things we should prioritize is:

  1. A "hero" code sample (suggested by @bterlson). This is a little tricky because of how important file paths are for the resolver. How do we communicate the file system hierarchy succinctly?
  2. Some kind of playground for people to try out components.

@acorncom
Copy link
Member Author

Re: "hero" code sample, @locks and I had been discussing reworking the guides to implement the weather widget shown in the video. We could also have a few simple widgets on the homepage ...

@locks
Copy link
Collaborator

locks commented Mar 29, 2017

Pinging @whitneyland as they were the originators of the feedback!

@max
Copy link
Collaborator

max commented Mar 29, 2017

The initial mockup included a code sample. It also shows the paths (I can make it clearer with a faux file browser to the left).

@bterlson
Copy link

@max fwiw I like the "tabs" showing the path of the file 👍. File browser might be too much. If you make sure that the most illustrative sample is on the tab that shows by default you might be fine. $0.02; not a designer.

@whitneyland
Copy link

whitneyland commented Mar 29, 2017

thanks all for being receptive, it takes a stronger person to not get defensive. maybe that's human nature because we're all passionate about our work.

@wycats
Copy link
Collaborator

wycats commented Apr 9, 2017

@tomdale we had discussed using some of the ideas in your original mockup (especially above-the-fold code). Are you working on that?

@locks locks closed this as completed Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants