Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: Enhanced history view #187

Open
EmilyDirsh opened this issue Jan 18, 2015 · 3 comments
Open

RFE: Enhanced history view #187

EmilyDirsh opened this issue Jan 18, 2015 · 3 comments

Comments

@EmilyDirsh
Copy link
Contributor

It'd be extremely useful for collaboration to present the history of a file along with any associated discussion inline.

Something along the lines of

|‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾|
|        Vers 1       |
|_____________________|
 - comment
         op comment - 
 - comment
|‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾|
|        Vers 2       |
|_____________________|
         op comment - 
 - comment
|‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾|
|        Vers 3       |
|_____________________|
 - comment
 - comment
         op comment - 
 - comment

etc....

May want it to be in reverse order to this so the most recent is at the top, but that will disrupt the flow of conversation, so we should discuss it.

@ChenLiZhan
Copy link

It's my first touch in this project, and I'm interested in this issue.

Is it under the 'Current' or 'Log' tab? For current website, we can leave comments for any specific version and leave comments without clicking into a single version. Should we choose only one way to comment?

@EmilyDirsh
Copy link
Contributor Author

This would be the history view, which is under the log tab. I think we should keep the commenting in multiple places, unless it's causing a lot of problems.

There are a number of use cases for commenting on older versions of an image, so I'd prefer to keep that.

@ChenLiZhan
Copy link

Okay! So do you want to display the comments associated with the version. What do you think we can limit the amount of comments and hide the extra comments. If users want to see the full conversation, they can just click "more" to see the full talk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants