refactor: replace all icons with iconify ones #144
Conversation
✅ Deploy Preview for sefirot-story ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportBase: 32.85% // Head: 35.18% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
==========================================
+ Coverage 32.85% 35.18% +2.32%
==========================================
Files 178 95 -83
Lines 8445 7866 -579
Branches 126 126
==========================================
- Hits 2775 2768 -7
+ Misses 5670 5098 -572
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
✅ Deploy Preview for sefirot-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| @@ -608,15 +608,16 @@ function handleClick(): void { | |||
|
|
|||
| .icon-svg { | |||
| fill: currentColor; | |||
| transition: fill 0.25s; | |||
| transition-property: color, fill; | |||
There was a problem hiding this comment.
Earlier there were no transitions (color was being modified but fill was set to currentColor, browsers don't animate that. Ref.). These changes will animate them, but I don't think we need these transitions. Open SButton > Icon on Histoire (main deploy) and try changing the color mode (cmd+shift+d). Do the same for preview deploy. There seems sort of delay in current version.
|
Thanks a lot! I was thinking to go with Phosphor and ditch Feather 👀
There's actually one, that currently uses this version of Sefirot, so I'll update that project as well. I'll merge this one first, and then work on with the project 👍 I'll take over the PR from here 🙌 (including changes to Phosphor icons as well |
|
I've migrated to |
closes #140
Note: We were (and are) using "Feather Icons". These aren't there on the Icones website. The ones present there are "Feather Icon" (no trailing
s😅). So for searching use the official tool instead of Icones. (x-ref: antfu-collective/icones#93)Also, IG the dependent projects will need to first migrate before merging this. Or we can probably restore the icons directory for now. And when all of them are using iconify icons, we can remove it.
Since feather icons are stroke-based (we had earlier modified them to be fill-based), there are certain changes to use
colorinstead offill.fill: currentColoris still present where icon is a prop, otherwise it's removed.