Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): invalid prop type error thrown on color prop (#157) #161

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Oct 20, 2022

fix #157

@kiaking kiaking added the bug Something isn't working label Oct 20, 2022
@kiaking kiaking requested a review from ryo-gk as a code owner October 20, 2022 06:02
@kiaking kiaking self-assigned this Oct 20, 2022
@netlify
Copy link

netlify bot commented Oct 20, 2022

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit 49ddc53
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/6350e4834fc9490008f494f1
😎 Deploy Preview https://deploy-preview-161--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 20, 2022

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit 49ddc53
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/6350e483edd4dd00084506c8
😎 Deploy Preview https://deploy-preview-161--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 35.01% // Head: 35.00% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (49ddc53) compared to base (64301f8).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
- Coverage   35.01%   35.00%   -0.01%     
==========================================
  Files          99       99              
  Lines        7949     7950       +1     
  Branches      131      131              
==========================================
  Hits         2783     2783              
- Misses       5166     5167       +1     
Impacted Files Coverage Δ
lib/components/STableCellPill.vue 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kiaking kiaking merged commit 48c465d into main Oct 20, 2022
@kiaking kiaking deleted the table-fix-invalid-prop-type branch October 20, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

defineProps compiler macro can't handle imported types
2 participants