Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input-number): display value style is broken (#158) #162

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Oct 20, 2022

fix #158

I've also just fixed the code style for this component.

@kiaking kiaking added the enhancement New feature or request label Oct 20, 2022
@kiaking kiaking self-assigned this Oct 20, 2022
@netlify
Copy link

netlify bot commented Oct 20, 2022

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit e647fb4
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/6350ee96d9eb860009b56b2c
😎 Deploy Preview https://deploy-preview-162--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 20, 2022

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit e647fb4
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/6350ee9605117a0008703c92
😎 Deploy Preview https://deploy-preview-162--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 35.01% // Head: 35.10% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (e647fb4) compared to base (64301f8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
+ Coverage   35.01%   35.10%   +0.09%     
==========================================
  Files          99       99              
  Lines        7949     7961      +12     
  Branches      131      131              
==========================================
+ Hits         2783     2795      +12     
  Misses       5166     5166              
Impacted Files Coverage Δ
lib/components/SInputNumber.vue 100.00% <100.00%> (ø)
lib/components/SInputText.vue 97.47% <100.00%> (+0.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kiaking kiaking merged commit 23f3acb into main Oct 20, 2022
@kiaking kiaking deleted the input-number-fix-display-value-style branch October 20, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SInputNumber] Style is broken when separator option is set to true
1 participant