Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SInputDropdown): change border color on error #163

Merged
merged 1 commit into from
Oct 20, 2022
Merged

fix(SInputDropdown): change border color on error #163

merged 1 commit into from
Oct 20, 2022

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Oct 20, 2022

fixes #160

@netlify
Copy link

netlify bot commented Oct 20, 2022

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit ed420da
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/6350f66f1967cd000ada005e
😎 Deploy Preview https://deploy-preview-163--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 20, 2022

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit ed420da
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/6350f66f53a2bd000978bcb6
😎 Deploy Preview https://deploy-preview-163--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 35.01% // Head: 35.01% // No change to project coverage 👍

Coverage data is based on head (ed420da) compared to base (64301f8).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #163   +/-   ##
=======================================
  Coverage   35.01%   35.01%           
=======================================
  Files          99       99           
  Lines        7949     7949           
  Branches      131      131           
=======================================
  Hits         2783     2783           
  Misses       5166     5166           
Impacted Files Coverage Δ
lib/components/SInputDropdown.vue 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah damn this was easy. Nice 👍

@kiaking kiaking merged commit c656801 into main Oct 20, 2022
@kiaking kiaking deleted the fix-160 branch October 20, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SInputDropdown] Error state missing border color
2 participants