Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): adjust spacing for text wrap #169

Merged
merged 2 commits into from
Oct 28, 2022
Merged

fix(dropdown): adjust spacing for text wrap #169

merged 2 commits into from
Oct 28, 2022

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Oct 28, 2022

fixes #168

image

@netlify
Copy link

netlify bot commented Oct 28, 2022

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit e8f7cc8
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/635ba3ebcf43b70008a79b40
😎 Deploy Preview https://deploy-preview-169--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 28, 2022

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit e8f7cc8
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/635ba3ebcf43b70008a79b45
😎 Deploy Preview https://deploy-preview-169--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Base: 34.43% // Head: 34.36% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (e8f7cc8) compared to base (e06be6c).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   34.43%   34.36%   -0.08%     
==========================================
  Files          99       99              
  Lines        7933     7951      +18     
  Branches      132      132              
==========================================
  Hits         2732     2732              
- Misses       5201     5219      +18     
Impacted Files Coverage Δ
lib/components/SDropdownSectionFilter.vue 0.00% <0.00%> (ø)
...ib/components/SDropdownSectionFilterItemAvatar.vue 0.00% <0.00%> (ø)
lib/components/SDropdownSectionFilterItemText.vue 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thaaaaanks! Just adjusted a bit more on design side 👍

@kiaking kiaking merged commit ee74598 into main Oct 28, 2022
@kiaking kiaking deleted the fix-168 branch October 28, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dropdown] Text option text gets wrapped weirdly
2 participants