feat(input): add addon-* slots
#206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sefirot-story ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportBase: 67.98% // Head: 69.44% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
==========================================
+ Coverage 67.98% 69.44% +1.45%
==========================================
Files 105 106 +1
Lines 8402 8636 +234
Branches 328 369 +41
==========================================
+ Hits 5712 5997 +285
+ Misses 2690 2639 -51
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
✅ Deploy Preview for sefirot-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ryo-gk
reviewed
Jan 30, 2023
kiaking
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
Thanks a lot! Looking good. Adjusted few stuff here and there.
- Added tests and docs.
- Changed props default to be true (e.g. unclickable -> clickable).
- Cleaned up stories.
- Cleaned up styles along with
<SInputText>. - Moved some functions into
Dropdowncomposable.
NozomuIkuta
commented
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana: https://app.asana.com/0/1130160932501704/1203800531766512/f
Resolves #202
I believe I covered all the necessary use cases in Histoire.