-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add unit-*
props to SInputText
and SInputNumber
#210
Conversation
✅ Deploy Preview for sefirot-story ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportBase: 69.52% // Head: 69.78% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
==========================================
+ Coverage 69.52% 69.78% +0.26%
==========================================
Files 106 106
Lines 8797 8874 +77
Branches 367 368 +1
==========================================
+ Hits 6116 6193 +77
Misses 2681 2681
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
✅ Deploy Preview for sefirot-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woot woot 🙌
I added
unit-before
andunit-after
props toSInputText
andSInputNumber
.Additionally, I modified Histoire's story controls for us to test UI interactively.