Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add unit-* props to SInputText and SInputNumber #210

Merged
merged 3 commits into from
Jan 31, 2023

Conversation

NozomuIkuta
Copy link
Contributor

I added unit-before and unit-after props to SInputText and SInputNumber.

Additionally, I modified Histoire's story controls for us to test UI interactively.

@NozomuIkuta NozomuIkuta self-assigned this Jan 31, 2023
@netlify
Copy link

netlify bot commented Jan 31, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit be341f5
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/63d88bc3b0f1460009740255
😎 Deploy Preview https://deploy-preview-210--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Base: 69.52% // Head: 69.78% // Increases project coverage by +0.26% 🎉

Coverage data is based on head (0270c89) compared to base (b06e66f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
+ Coverage   69.52%   69.78%   +0.26%     
==========================================
  Files         106      106              
  Lines        8797     8874      +77     
  Branches      367      368       +1     
==========================================
+ Hits         6116     6193      +77     
  Misses       2681     2681              
Impacted Files Coverage Δ
lib/components/SInputNumber.vue 100.00% <100.00%> (ø)
lib/components/SInputText.vue 98.29% <100.00%> (+0.31%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@netlify
Copy link

netlify bot commented Jan 31, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit be341f5
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/63d88bc379720f0008078bbf
😎 Deploy Preview https://deploy-preview-210--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot woot 🙌

@kiaking kiaking added the enhancement New feature or request label Jan 31, 2023
@kiaking kiaking merged commit 0593a89 into main Jan 31, 2023
@kiaking kiaking deleted the feat/input-text-unit-before-after branch January 31, 2023 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants