Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dropdown): add actions type (#225) #227

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Feb 27, 2023

close #225

API is exactly the same as described in #225.

Screenshot 2023-02-27 at 15 19 25

@kiaking kiaking added the enhancement New feature or request label Feb 27, 2023
@kiaking kiaking requested a review from ryo-gk February 27, 2023 06:21
@kiaking kiaking self-assigned this Feb 27, 2023
@netlify
Copy link

netlify bot commented Feb 27, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit 1c7ba2d
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/63fc4befc631860008236089
😎 Deploy Preview https://deploy-preview-227--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 27, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit 1c7ba2d
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/63fc4bef1e5bf80008cb301c
😎 Deploy Preview https://deploy-preview-227--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Base: 76.03% // Head: 76.26% // Increases project coverage by +0.23% 🎉

Coverage data is based on head (1c7ba2d) compared to base (ce1dc49).
Patch coverage: 98.73% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
+ Coverage   76.03%   76.26%   +0.23%     
==========================================
  Files         107      108       +1     
  Lines        8801     8879      +78     
  Branches      432      434       +2     
==========================================
+ Hits         6692     6772      +80     
+ Misses       2109     2107       -2     
Impacted Files Coverage Δ
lib/components/SDropdownSection.vue 94.82% <80.00%> (+4.26%) ⬆️
lib/components/SDropdownSectionActions.vue 100.00% <100.00%> (ø)
lib/composables/Dropdown.ts 98.62% <100.00%> (+0.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kiaking kiaking merged commit 7e3361c into main Feb 28, 2023
@kiaking kiaking deleted the 225-dropdown-add-actions-type branch February 28, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dropdown] Add actions type
1 participant