Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add size props to SInputDate #229

Merged
merged 2 commits into from
Mar 20, 2023
Merged

feat: add size props to SInputDate #229

merged 2 commits into from
Mar 20, 2023

Conversation

ryo-gk
Copy link
Member

@ryo-gk ryo-gk commented Mar 16, 2023

This PR adds size prop to SInputDate.
Basically the style for each sizes is same as SInputText.

@ryo-gk ryo-gk added the enhancement New feature or request label Mar 16, 2023
@ryo-gk ryo-gk requested a review from kiaking March 16, 2023 07:22
@ryo-gk ryo-gk self-assigned this Mar 16, 2023
@netlify
Copy link

netlify bot commented Mar 16, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit 699788b
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/6417bcaf2902c60007fee566
😎 Deploy Preview https://deploy-preview-229--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 16, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit 699788b
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/6417bcafb6d1ab00084c7973
😎 Deploy Preview https://deploy-preview-229--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.38 🎉

Comparison is base (3ae8817) 78.65% compared to head (699788b) 80.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
+ Coverage   78.65%   80.04%   +1.38%     
==========================================
  Files         112      112              
  Lines        9305     9335      +30     
  Branches      477      347     -130     
==========================================
+ Hits         7319     7472     +153     
+ Misses       1986     1863     -123     
Impacted Files Coverage Δ
lib/components/SInputDate.vue 98.70% <100.00%> (+98.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiice!

@kiaking kiaking merged commit 120fd68 into main Mar 20, 2023
@kiaking kiaking deleted the feat/date-input-size-prop branch March 20, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants