-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(table): allow adding summary row #231
Conversation
✅ Deploy Preview for sefirot-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for sefirot-story ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #231 +/- ##
==========================================
- Coverage 80.04% 79.50% -0.55%
==========================================
Files 112 112
Lines 9335 9366 +31
Branches 347 368 +21
==========================================
- Hits 7472 7446 -26
- Misses 1863 1920 +57
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking nice! Very smart 👍
Yap! Currently updating records are manual so, if the summary should change on page change, it should be done at user land. Just pass reactive value to
hmmmm something happening on Histoire I guess 🤔 ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a bunch! I've adjusted the style and defined new css var for font weight.
fixes #230
Pagination is not working (at least not on Histoire), so not sure how it will play with that 👀onPrev
/onNext
is empty there, will check if it works fine or notAlso, on filtering, there are a bunch of errors (not related to this PR):
TODO: