Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(button): add icon-mode and label-mode props #241

Merged
merged 5 commits into from
Apr 10, 2023
Merged

feat(button): add icon-mode and label-mode props #241

merged 5 commits into from
Apr 10, 2023

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Apr 6, 2023

fixes #235

@netlify
Copy link

netlify bot commented Apr 6, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit e26f04a
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/64336c7393efac0008274e84
😎 Deploy Preview https://deploy-preview-241--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 6, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit e26f04a
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/64336c7346d6b10008cf5c8c
😎 Deploy Preview https://deploy-preview-241--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@brc-dd brc-dd marked this pull request as ready for review April 6, 2023 15:45
Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Added a comment 🙏

docs/components/button.md Outdated Show resolved Hide resolved
@kiaking
Copy link
Member

kiaking commented Apr 7, 2023

And sorry can we also include label-mode that changes only the label color of the button? To have this kind of style.

Screenshot 2023-04-07 at 10 14 17

This should be done by <SButton :mode="mute" :label-mode="danger" />.

BTW, we could have content-mode prop that would change both icon and label color but not BG at this pont... though that might be too much (we can simply define 2 props if there's such a use case). So, I think we wouldn't need it 🤔

@brc-dd brc-dd changed the title feat(button): add icon-mode prop feat(button): add icon-mode and label-mode props Apr 7, 2023
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.16 🎉

Comparison is base (4b28a2d) 79.56% compared to head (e26f04a) 79.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
+ Coverage   79.56%   79.73%   +0.16%     
==========================================
  Files         112      112              
  Lines        9405     9483      +78     
  Branches      369      370       +1     
==========================================
+ Hits         7483     7561      +78     
  Misses       1922     1922              
Impacted Files Coverage Δ
lib/components/SButton.vue 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kiaking kiaking merged commit 7c84109 into main Apr 10, 2023
11 checks passed
@kiaking kiaking deleted the fix/235 branch April 10, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Button] add option to change only the icon color
2 participants