Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table): add TableCellState type #251

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Conversation

cuebit
Copy link
Member

@cuebit cuebit commented Apr 14, 2023

resolves #248

Screenshot 2023-04-14 at 17 16 05

@netlify
Copy link

netlify bot commented Apr 14, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit c3663b1
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/64397b451658a20008a97055
😎 Deploy Preview https://deploy-preview-251--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cuebit cuebit changed the title feat: add TableCellState type feat(table): add TableCellState type Apr 14, 2023
@netlify
Copy link

netlify bot commented Apr 14, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit c3663b1
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/64397b45c60e9d000847d338
😎 Deploy Preview https://deploy-preview-251--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage: 87.80% and project coverage change: +0.03 🎉

Comparison is base (687f3da) 79.88% compared to head (c3663b1) 79.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
+ Coverage   79.88%   79.91%   +0.03%     
==========================================
  Files         113      114       +1     
  Lines        9742     9783      +41     
  Branches      387      387              
==========================================
+ Hits         7782     7818      +36     
- Misses       1960     1965       +5     
Impacted Files Coverage Δ
lib/components/STableCell.vue 55.83% <16.66%> (-2.07%) ⬇️
lib/components/STableCellState.vue 100.00% <100.00%> (ø)
lib/composables/Table.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cuebit
Copy link
Member Author

cuebit commented Apr 14, 2023

It's worth noting that :record and :getter is omitted since this methodology of resolving values will be obsolete. See below note from @kiaking:

NOTE: We don't need callback signature. I think we can make it deprecated for other fields that currently have since we now can make TableCell itself a callback in columns option.

// If you need to do this.
{
  cell: {
    type: 'state',
    value: (_, record) => record.someThing
  }
}

// Do this instead.
{
  cell: (_, record) => ({
    type: 'state',
    value: record.someThing
  })
}

@cuebit cuebit marked this pull request as ready for review April 14, 2023 16:22
@cuebit cuebit added the enhancement New feature or request label Apr 14, 2023
Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiice! Perfect. Thank you so much 🙌

@kiaking kiaking merged commit 3f74439 into main Apr 17, 2023
11 checks passed
@kiaking kiaking deleted the feat/248-tablecellstate branch April 17, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Table] Add TableCellState type
4 participants