Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(STable): missing unref orders #254

Merged
merged 1 commit into from
Apr 18, 2023
Merged

fix(STable): missing unref orders #254

merged 1 commit into from
Apr 18, 2023

Conversation

ryo-gk
Copy link
Member

@ryo-gk ryo-gk commented Apr 18, 2023

Fix missing unref options.orders which causes error in some cases.

@ryo-gk ryo-gk added the bug Something isn't working label Apr 18, 2023
@ryo-gk ryo-gk requested review from kiaking and brc-dd April 18, 2023 01:39
@ryo-gk ryo-gk self-assigned this Apr 18, 2023
@netlify
Copy link

netlify bot commented Apr 18, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit 5c28fa3
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/643df4d7b257540008305815
😎 Deploy Preview https://deploy-preview-254--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 18, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit 5c28fa3
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/643df4d76bc38a0008a187dd
😎 Deploy Preview https://deploy-preview-254--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (41c7902) 79.91% compared to head (5c28fa3) 79.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #254   +/-   ##
=======================================
  Coverage   79.91%   79.91%           
=======================================
  Files         114      114           
  Lines        9783     9783           
  Branches      387      387           
=======================================
  Hits         7818     7818           
  Misses       1965     1965           
Impacted Files Coverage Δ
lib/components/STable.vue 80.37% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kiaking kiaking merged commit 53f66e8 into main Apr 18, 2023
11 checks passed
@kiaking kiaking deleted the fix/missing-unref-orders branch April 18, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants