Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SButton): emit disabled-click (#255) #261

Merged
merged 2 commits into from
Apr 21, 2023
Merged

feat(SButton): emit disabled-click (#255) #261

merged 2 commits into from
Apr 21, 2023

Conversation

cuebit
Copy link
Member

@cuebit cuebit commented Apr 21, 2023

resolves #257

@cuebit cuebit added the enhancement New feature or request label Apr 21, 2023
@cuebit cuebit requested a review from kiaking April 21, 2023 02:17
@cuebit cuebit self-assigned this Apr 21, 2023
@netlify
Copy link

netlify bot commented Apr 21, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit 31c0dc7
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/6441f8c4d0ec370008d7aa76
😎 Deploy Preview https://deploy-preview-261--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 21, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit 31c0dc7
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/6441f8c4d2330f00088046a5
😎 Deploy Preview https://deploy-preview-261--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d9298a8) 79.91% compared to head (31c0dc7) 79.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #261   +/-   ##
=======================================
  Coverage   79.91%   79.92%           
=======================================
  Files         114      114           
  Lines        9789     9792    +3     
  Branches      389      390    +1     
=======================================
+ Hits         7823     7826    +3     
  Misses       1966     1966           
Impacted Files Coverage Δ
lib/components/SButton.vue 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks 🙌 I've added the docs 💪

@kiaking kiaking merged commit 87b963c into main Apr 21, 2023
11 checks passed
@kiaking kiaking deleted the patch-257 branch April 21, 2023 02:54
@cuebit
Copy link
Member Author

cuebit commented Apr 21, 2023

Ah, completely overlooked. Thanks for adding the docs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Button] Emit @disabled-click event
2 participants