-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: error on set placeholder partially #269
Conversation
✅ Deploy Preview for sefirot-story ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for sefirot-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
=======================================
Coverage 80.32% 80.32%
=======================================
Files 114 114
Lines 9887 9887
Branches 411 411
=======================================
Hits 7942 7942
Misses 1945 1945
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update the Placeholder
types as well since they are not nullable 👀 It should be:
export interface Placeholder {
hour?: string
minute?: string
second?: string
}
Same goes for |
Ah, I mistook the Placeholder in SInputYMD for Value and thought it was okay. 😓 |
This PR fixes the issue that it causes the error when we set the placeholder to
SInputYMD
andSInputHMS
partially.