-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: error on accessing nullable variables #277
Conversation
✅ Deploy Preview for sefirot-story ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
=======================================
Coverage 80.08% 80.08%
=======================================
Files 115 115
Lines 9983 9983
Branches 406 406
=======================================
Hits 7995 7995
Misses 1988 1988
☔ View full report in Codecov by Sentry. |
✅ Deploy Preview for sefirot-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me.
@brc-dd Could you take a look? 👀
LGTM, but why aren't these handled by TS in the first place? (I see that everything in the flyout composable is |
I'm pretty sure because we were too lazy 😅 |
Fix the error which occurs when
container
element is null.