Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error on accessing nullable variables #277

Merged
merged 2 commits into from
May 23, 2023
Merged

Conversation

ryo-gk
Copy link
Member

@ryo-gk ryo-gk commented May 22, 2023

Fix the error which occurs when container element is null.

@ryo-gk ryo-gk added the bug Something isn't working label May 22, 2023
@ryo-gk ryo-gk requested a review from kiaking May 22, 2023 01:45
@ryo-gk ryo-gk self-assigned this May 22, 2023
@netlify
Copy link

netlify bot commented May 22, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit da8e9c1
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/646c471efa8df000080b9b32
😎 Deploy Preview https://deploy-preview-277--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b3d5fb1) 80.08% compared to head (da8e9c1) 80.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #277   +/-   ##
=======================================
  Coverage   80.08%   80.08%           
=======================================
  Files         115      115           
  Lines        9983     9983           
  Branches      406      406           
=======================================
  Hits         7995     7995           
  Misses       1988     1988           
Impacted Files Coverage Δ
lib/components/STableColumn.vue 76.36% <0.00%> (ø)
lib/composables/Flyout.ts 74.46% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@netlify
Copy link

netlify bot commented May 22, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit da8e9c1
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/646c471db42877000700d0b8
😎 Deploy Preview https://deploy-preview-277--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@brc-dd Could you take a look? 👀

@kiaking kiaking requested a review from brc-dd May 23, 2023 04:18
lib/composables/Flyout.ts Outdated Show resolved Hide resolved
@brc-dd
Copy link
Member

brc-dd commented May 23, 2023

LGTM, but why aren't these handled by TS in the first place? (I see that everything in the flyout composable is any.)

@kiaking
Copy link
Member

kiaking commented May 23, 2023

LGTM, but why aren't these handled by TS in the first place? (I see that everything in the flyout composable is any.)

I'm pretty sure because we were too lazy 😅

@kiaking kiaking merged commit c6372bf into main May 23, 2023
12 of 13 checks passed
@kiaking kiaking deleted the fix/null-access-error branch May 23, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants