Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(form): allow specifying message in validateAndNotify #287

Merged
merged 1 commit into from
May 26, 2023
Merged

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented May 26, 2023

fixes #284

@netlify
Copy link

netlify bot commented May 26, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit 716f2ce
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/6470695a9717340007a81ed7
😎 Deploy Preview https://deploy-preview-287--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 26, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit 716f2ce
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/6470695a1792ef000876db39
😎 Deploy Preview https://deploy-preview-287--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (976081b) 82.80% compared to head (716f2ce) 82.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #287   +/-   ##
=======================================
  Coverage   82.80%   82.80%           
=======================================
  Files         120      120           
  Lines       10090    10090           
  Branches      419      419           
=======================================
  Hits         8355     8355           
  Misses       1735     1735           
Impacted Files Coverage Δ
lib/composables/Form.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kiaking kiaking merged commit 9a136a8 into main May 26, 2023
12 of 13 checks passed
@kiaking kiaking deleted the fix/284 branch May 26, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Form] add option to specify message for validateAndNotify
2 participants