Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table): add onClick option to TableCellAvatar #292

Merged
merged 4 commits into from
May 31, 2023

Conversation

NozomuIkuta
Copy link
Contributor

Resolves #291.

I'm not sure if we can use anonymous.png and where to store it.

@netlify
Copy link

netlify bot commented May 30, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit b5890a5
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/6476986bcddf830008eff12b
😎 Deploy Preview https://deploy-preview-292--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 30, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit b5890a5
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/6476986b9ab73b0008f7c8b6
😎 Deploy Preview https://deploy-preview-292--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage: 90.00% and no project coverage change.

Comparison is base (f95e5e6) 82.88% compared to head (b5890a5) 82.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #292   +/-   ##
=======================================
  Coverage   82.88%   82.89%           
=======================================
  Files         120      120           
  Lines       10098    10106    +8     
  Branches      420      420           
=======================================
+ Hits         8370     8377    +7     
- Misses       1728     1729    +1     
Impacted Files Coverage Δ
lib/components/STableCell.vue 55.37% <0.00%> (-0.47%) ⬇️
lib/components/STableCellAvatar.vue 100.00% <100.00%> (ø)
lib/composables/Table.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kiaking
Copy link
Member

kiaking commented May 31, 2023

Ahh good point. I think this image is for example only so let's use GitHub avatar link so that we don't have to store anything in this repo 🤔 Everything looks good so I'll just gonna fix it and merge this 🙌

@kiaking
Copy link
Member

kiaking commented May 31, 2023

OK I've adjusted the format a bit and removed the image for now and reverted the story change, since I felt a bit awkward having exact same anonymous user avatar and the name was Artwork so 😅 We could always create a new story with avatar type focused example though 👍

@kiaking kiaking changed the title feat: add onClick to TableCellAvatar feat(table): add onClick option to TableCellAvatar May 31, 2023
@kiaking kiaking added the enhancement New feature or request label May 31, 2023
@kiaking kiaking merged commit ab0111c into main May 31, 2023
13 checks passed
@kiaking kiaking deleted the feat/table-cell-avatar-onclick branch May 31, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Table] Add onClick property for Avatar type cell
2 participants