-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(table): add onClick
option to TableCellAvatar
#292
Conversation
✅ Deploy Preview for sefirot-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for sefirot-story ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #292 +/- ##
=======================================
Coverage 82.88% 82.89%
=======================================
Files 120 120
Lines 10098 10106 +8
Branches 420 420
=======================================
+ Hits 8370 8377 +7
- Misses 1728 1729 +1
☔ View full report in Codecov by Sentry. |
Ahh good point. I think this image is for example only so let's use GitHub avatar link so that we don't have to store anything in this repo 🤔 Everything looks good so I'll just gonna fix it and merge this 🙌 |
OK I've adjusted the format a bit and removed the image for now and reverted the story change, since I felt a bit awkward having exact same anonymous user avatar and the name was Artwork so 😅 We could always create a new story with avatar type focused example though 👍 |
onClick
to TableCellAvatar
onClick
option to TableCellAvatar
Resolves #291.
I'm not sure if we can use
anonymous.png
and where to store it.