Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(link): add external prop to SLink (#293) #294

Merged
merged 3 commits into from
May 31, 2023
Merged

Conversation

NozomuIkuta
Copy link
Contributor

Resolves #293

@NozomuIkuta NozomuIkuta requested a review from kiaking May 31, 2023 04:31
@NozomuIkuta NozomuIkuta self-assigned this May 31, 2023
@netlify
Copy link

netlify bot commented May 31, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit 0dd01fd
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/6476e9aa63d110000814f300
😎 Deploy Preview https://deploy-preview-294--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 31, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit 0dd01fd
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/6476e9aaf897ff0008b1649a
😎 Deploy Preview https://deploy-preview-294--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (864c9c5) 82.89% compared to head (0dd01fd) 82.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #294      +/-   ##
==========================================
+ Coverage   82.89%   82.91%   +0.02%     
==========================================
  Files         120      120              
  Lines       10106    10119      +13     
  Branches      420      423       +3     
==========================================
+ Hits         8377     8390      +13     
  Misses       1729     1729              
Impacted Files Coverage Δ
lib/components/SLink.vue 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have:

  • Fix :external default value issue (always false).
  • Adjust story.
  • Add test.
  • Add docs.

@kiaking kiaking changed the title feat: add external prop to SLink feat(link): add external prop to SLink #293 May 31, 2023
@kiaking kiaking changed the title feat(link): add external prop to SLink #293 feat(link): add external prop to SLink (#293) May 31, 2023
@kiaking kiaking merged commit 9179f1d into main May 31, 2023
13 checks passed
@kiaking kiaking deleted the feat/external-link branch May 31, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Link] same-origin link is always opened in the same browser tab
2 participants