-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(link): add external
prop to SLink
(#293)
#294
Conversation
✅ Deploy Preview for sefirot-story ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for sefirot-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #294 +/- ##
==========================================
+ Coverage 82.89% 82.91% +0.02%
==========================================
Files 120 120
Lines 10106 10119 +13
Branches 420 423 +3
==========================================
+ Hits 8377 8390 +13
Misses 1729 1729
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have:
- Fix
:external
default value issue (always false). - Adjust story.
- Add test.
- Add docs.
external
prop to SLink
external
prop to SLink
#293
external
prop to SLink
#293external
prop to SLink
(#293)
Resolves #293