Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table): add :align option (#295) #299

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Jun 7, 2023

Add :align option to "text", "number", and "day" cell type. I have secretly adjusted "day" type component font and format. 👀

@kiaking kiaking added the enhancement New feature or request label Jun 7, 2023
@kiaking kiaking requested a review from brc-dd June 7, 2023 01:27
@kiaking kiaking self-assigned this Jun 7, 2023
@netlify
Copy link

netlify bot commented Jun 7, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit 7d61436
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/647fdd0966e0ce000745a14c
😎 Deploy Preview https://deploy-preview-299--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 7, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit 7d61436
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/647fdd0901e26d000829b898
😎 Deploy Preview https://deploy-preview-299--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage: 92.30% and project coverage change: +0.01 🎉

Comparison is base (5ff4ee7) 83.40% compared to head (7d61436) 83.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
+ Coverage   83.40%   83.42%   +0.01%     
==========================================
  Files         123      123              
  Lines       10464    10486      +22     
  Branches      566      567       +1     
==========================================
+ Hits         8728     8748      +20     
- Misses       1736     1738       +2     
Impacted Files Coverage Δ
lib/components/STableCell.vue 50.36% <33.33%> (-0.39%) ⬇️
lib/components/STableCellDay.vue 100.00% <100.00%> (ø)
lib/components/STableCellNumber.vue 100.00% <100.00%> (ø)
lib/components/STableCellText.vue 95.06% <100.00%> (+0.15%) ⬆️
lib/composables/Table.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kiaking kiaking merged commit d2a6a61 into main Jun 7, 2023
15 checks passed
@kiaking kiaking deleted the 295-table-align-option branch June 7, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Table] Add option to align cell content
2 participants