Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dropdown): allow disabling menu options #307

Merged
merged 1 commit into from
Jun 19, 2023
Merged

feat(dropdown): allow disabling menu options #307

merged 1 commit into from
Jun 19, 2023

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Jun 19, 2023

resolves #306

image

@netlify
Copy link

netlify bot commented Jun 19, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit fafc8c1
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/648ffb9f63108d00089748e7
😎 Deploy Preview https://deploy-preview-307--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 19, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit fafc8c1
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/648ffb9f63108d00089748ec
😎 Deploy Preview https://deploy-preview-307--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@brc-dd brc-dd marked this pull request as ready for review June 19, 2023 06:55
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (00b2e45) 83.56% compared to head (fafc8c1) 83.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
+ Coverage   83.56%   83.58%   +0.01%     
==========================================
  Files         123      123              
  Lines       10502    10512      +10     
  Branches      578      448     -130     
==========================================
+ Hits         8776     8786      +10     
  Misses       1726     1726              
Impacted Files Coverage Δ
lib/components/SDropdownSectionMenu.vue 100.00% <100.00%> (ø)
lib/composables/Dropdown.ts 98.64% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kiaking kiaking merged commit cbfa10d into main Jun 19, 2023
13 checks passed
@kiaking kiaking deleted the fix/306 branch June 19, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dropdown] Add disabled property to DropdownSectionMenuOption
3 participants