Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grid): add <SGrid> component #313

Merged
merged 2 commits into from
Jul 19, 2023
Merged

feat(grid): add <SGrid> component #313

merged 2 commits into from
Jul 19, 2023

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Jul 12, 2023

Add <SGrid> component.

This is a utility component that makes it a bit easy to define CSS Grid. Especially useful on apps that don't require responsive design. It just reduces a lot of boiler plate CSS and we quite use this a lot.

<SGrid cols="4" gap="24">
  <SGridItem span="2">
    <div>...</div>
  </SGridItem>
  <SGridItem span="1">
    <div>...</div>
  </SGridItem>
</SGrid>
Screenshot 2023-07-12 at 14 53 29

@kiaking kiaking added the enhancement New feature or request label Jul 12, 2023
@kiaking kiaking self-assigned this Jul 12, 2023
@netlify
Copy link

netlify bot commented Jul 12, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit 23d3ddc
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/64b66b5d5f3b0a0008083b8c
😎 Deploy Preview https://deploy-preview-313--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06 🎉

Comparison is base (4546cab) 83.57% compared to head (23d3ddc) 83.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
+ Coverage   83.57%   83.63%   +0.06%     
==========================================
  Files         123      125       +2     
  Lines       10515    10556      +41     
  Branches      448      450       +2     
==========================================
+ Hits         8788     8829      +41     
  Misses       1727     1727              
Impacted Files Coverage Δ
lib/components/SGrid.vue 100.00% <100.00%> (ø)
lib/components/SGridItem.vue 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@netlify
Copy link

netlify bot commented Jul 12, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit 23d3ddc
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/64b66b5db013a00007e105ce
😎 Deploy Preview https://deploy-preview-313--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

docs/components/grid.md Show resolved Hide resolved
docs/components/grid.md Outdated Show resolved Hide resolved
Co-authored-by: Cue <hello@cuebit.dev>
@kiaking kiaking merged commit ec92c7b into main Jul 19, 2023
13 checks passed
@kiaking kiaking deleted the grid-component branch July 19, 2023 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants