Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(desc): add SDesc component #318

Merged
merged 8 commits into from
Jul 21, 2023
Merged

feat(desc): add SDesc component #318

merged 8 commits into from
Jul 21, 2023

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Jul 19, 2023

<SDesc> is a component to create "Description List".

Refer to the documentation on how to use this component.

Screenshot 2023-07-19 at 18 23 18

@kiaking kiaking added the enhancement New feature or request label Jul 19, 2023
@kiaking kiaking self-assigned this Jul 19, 2023
@kiaking kiaking marked this pull request as draft July 19, 2023 09:26
@netlify
Copy link

netlify bot commented Jul 19, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit d0d1209
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/64b9d33f408cbb0008645d4a
😎 Deploy Preview https://deploy-preview-318--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.56 🎉

Comparison is base (adbe875) 83.84% compared to head (d0d1209) 84.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #318      +/-   ##
==========================================
+ Coverage   83.84%   84.40%   +0.56%     
==========================================
  Files         129      139      +10     
  Lines       10692    11077     +385     
  Branches      450      489      +39     
==========================================
+ Hits         8965     9350     +385     
  Misses       1727     1727              
Impacted Files Coverage Δ
lib/components/SDesc.vue 100.00% <100.00%> (ø)
lib/components/SDescDay.vue 100.00% <100.00%> (ø)
lib/components/SDescEmpty.vue 100.00% <100.00%> (ø)
lib/components/SDescItem.vue 100.00% <100.00%> (ø)
lib/components/SDescLabel.vue 100.00% <100.00%> (ø)
lib/components/SDescLink.vue 100.00% <100.00%> (ø)
lib/components/SDescNumber.vue 100.00% <100.00%> (ø)
lib/components/SDescPill.vue 100.00% <100.00%> (ø)
lib/components/SDescState.vue 100.00% <100.00%> (ø)
lib/components/SDescText.vue 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@netlify
Copy link

netlify bot commented Jul 19, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit d0d1209
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/64b9d33f6a43870008f2d63f
😎 Deploy Preview https://deploy-preview-318--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kiaking kiaking marked this pull request as ready for review July 20, 2023 03:45
Copy link
Member

@cuebit cuebit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In another PR we briefly touched on the significance of <Component>, :prop and @event being self-explanatory therefore not requiring the use of words like prop and event immediately after them. This PR is a good example of where there is a mixed use of "Use <Foo> component to do something..." and "Use <Foo> to do something...". Should these also be treated in the same respect and ditch the use of the word component directly after?

docs/components/desc.md Outdated Show resolved Hide resolved
docs/components/desc.md Outdated Show resolved Hide resolved
Co-authored-by: Cue <hello@cuebit.dev>
@kiaking
Copy link
Member Author

kiaking commented Jul 21, 2023

@cuebit Ah good point. I wasn't thinking it too much but yeah by removing those the text get shorter so I'll update it 👍

kiaking and others added 2 commits July 21, 2023 09:30
Co-authored-by: Cue <hello@cuebit.dev>
@kiaking
Copy link
Member Author

kiaking commented Jul 21, 2023

Aaand updated!

@kiaking kiaking merged commit 9550ee5 into main Jul 21, 2023
13 checks passed
@kiaking kiaking deleted the desc branch July 21, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants