-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(desc): add SDesc
component
#318
Conversation
✅ Deploy Preview for sefirot-story ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #318 +/- ##
==========================================
+ Coverage 83.84% 84.40% +0.56%
==========================================
Files 129 139 +10
Lines 10692 11077 +385
Branches 450 489 +39
==========================================
+ Hits 8965 9350 +385
Misses 1727 1727
☔ View full report in Codecov by Sentry. |
✅ Deploy Preview for sefirot-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In another PR we briefly touched on the significance of <Component>
, :prop
and @event
being self-explanatory therefore not requiring the use of words like prop and event immediately after them. This PR is a good example of where there is a mixed use of "Use <Foo>
component to do something..." and "Use <Foo>
to do something...". Should these also be treated in the same respect and ditch the use of the word component directly after?
@cuebit Ah good point. I wasn't thinking it too much but yeah by removing those the text get shorter so I'll update it 👍 |
Co-authored-by: Cue <hello@cuebit.dev>
Aaand updated! |
<SDesc>
is a component to create "Description List".Refer to the documentation on how to use this component.