Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): reset white space wrapping #320

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Jul 20, 2023

closes #319

@netlify
Copy link

netlify bot commented Jul 20, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit fef99ac
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/64b8e4e60ad6f800081d08b7
😎 Deploy Preview https://deploy-preview-320--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 20, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit fef99ac
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/64b8e4e697b9480008f4e218
😎 Deploy Preview https://deploy-preview-320--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (adbe875) 83.84% compared to head (fef99ac) 83.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #320   +/-   ##
=======================================
  Coverage   83.84%   83.84%           
=======================================
  Files         129      129           
  Lines       10692    10693    +1     
  Branches      450      450           
=======================================
+ Hits         8965     8966    +1     
  Misses       1727     1727           
Impacted Files Coverage Δ
lib/components/SDropdown.vue 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed it's fixed! Thanks a bunch 🙌

@kiaking kiaking added the bug Something isn't working label Jul 20, 2023
@kiaking kiaking merged commit fe2264e into main Jul 20, 2023
13 checks passed
@kiaking kiaking deleted the fix/dropdown-in-table branch July 20, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Table] Unexpected horizontal scroll on dropdown when item text is too long
2 participants