Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grid): make styles overridable via CSS #323

Merged
merged 2 commits into from
Jul 31, 2023
Merged

fix(grid): make styles overridable via CSS #323

merged 2 commits into from
Jul 31, 2023

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Jul 26, 2023

fix #321

Can be verified by something like this in SGrid.01_Playground.story.vue:

<style scoped>
:deep(.SGrid) {
  grid-template-columns: repeat(2, minmax(0, 1fr));
  gap: 24px;
}
</style>

@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit 7758f0e
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/64c09ef27ffaad0008012d92
😎 Deploy Preview https://deploy-preview-323--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit 7758f0e
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/64c09ef2ab855a0008911c14
😎 Deploy Preview https://deploy-preview-323--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2d99920) 84.41% compared to head (7758f0e) 84.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #323   +/-   ##
=======================================
  Coverage   84.41%   84.41%           
=======================================
  Files         139      139           
  Lines       11078    11080    +2     
  Branches      489      491    +2     
=======================================
+ Hits         9351     9353    +2     
  Misses       1727     1727           
Files Changed Coverage Δ
lib/components/SGrid.vue 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed! Thanks a bunch 🙌

OK, now, how do we test this 🤔 ...

Screenshot 2023-07-26 at 12 40 08

@brc-dd
Copy link
Member Author

brc-dd commented Jul 26, 2023

Huh, can't seem to make that work. Here is a solution: vuejs/test-utils#1931 but that breaks other things 👀

@kiaking
Copy link
Member

kiaking commented Jul 31, 2023

Ah yeah, well too bad. This is hard one I guess 😅 Let's leave it for now 👍

@kiaking kiaking merged commit 843dd2b into main Jul 31, 2023
13 checks passed
@kiaking kiaking deleted the fix/321 branch July 31, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Grid] Styles not able to override with CSS
2 participants