Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(head): add :mode to title component #326

Merged
merged 1 commit into from
Jul 31, 2023
Merged

feat(head): add :mode to title component #326

merged 1 commit into from
Jul 31, 2023

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Jul 31, 2023

Add :mode to <SHeadTitle>. To create this design along with #325.

Screenshot 2023-07-31 at 17 39 11

@kiaking kiaking added the enhancement New feature or request label Jul 31, 2023
@kiaking kiaking requested review from cuebit and brc-dd July 31, 2023 08:51
@kiaking kiaking self-assigned this Jul 31, 2023
@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit 00a4baf
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/64c776300927800008914b03
😎 Deploy Preview https://deploy-preview-326--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit 00a4baf
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/64c776308da5320008234848
😎 Deploy Preview https://deploy-preview-326--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (cc26861) 84.41% compared to head (5d19348) 84.43%.

❗ Current head 5d19348 differs from pull request most recent head 00a4baf. Consider uploading reports for the commit 00a4baf to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
+ Coverage   84.41%   84.43%   +0.01%     
==========================================
  Files         139      139              
  Lines       11084    11097      +13     
  Branches      491      491              
==========================================
+ Hits         9357     9370      +13     
  Misses       1727     1727              
Files Changed Coverage Δ
lib/components/SHeadTitle.vue 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiaking kiaking merged commit 7cb95f8 into main Jul 31, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants