Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input-ymd): don't apply hover styles if input is disabled #331

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Aug 16, 2023

closes #330

SInputHMS already have this:

.SInputHMS.disabled {
.container,
.input {
cursor: not-allowed;
}
.container {
background-color: var(--input-disabled-bg-color);
}
.container:hover { border-color: var(--input-border-color); }
.container.focus { border-color: var(--input-border-color); }
}

@netlify
Copy link

netlify bot commented Aug 16, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit d56cb61
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/64dc9fb5c95e4b00095d029c
😎 Deploy Preview https://deploy-preview-331--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (97b1bf3) 84.52% compared to head (d56cb61) 84.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #331   +/-   ##
=======================================
  Coverage   84.52%   84.52%           
=======================================
  Files         139      139           
  Lines       11160    11163    +3     
  Branches      630      630           
=======================================
+ Hits         9433     9436    +3     
  Misses       1727     1727           
Files Changed Coverage Δ
lib/components/SInputYMD.vue 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@netlify
Copy link

netlify bot commented Aug 16, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit d56cb61
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/64dc9fb5dbfe7f00086aa972
😎 Deploy Preview https://deploy-preview-331--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch!

@kiaking kiaking merged commit 9257cca into main Aug 17, 2023
13 checks passed
@kiaking kiaking deleted the fix/330 branch August 17, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SInputYmd] Hover styles are enabled even when disabled prop is true
2 participants