feat(desc): add :dir option
#332
Merged
+215
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sefirot-story ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for sefirot-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
==========================================
- Coverage 84.52% 84.51% -0.02%
==========================================
Files 139 139
Lines 11163 11165 +2
Branches 630 630
==========================================
Hits 9436 9436
- Misses 1727 1729 +2
☔ View full report in Codecov by Sentry. |
|
Is this expected for Screen.Recording.2023-08-24.at.12.56.09.PM.movIG it should be like this (similar to 
|
Ah shit, I'm gonna remove that option from story. That behaviour is expected. That's happening because "About" section has |
brc-dd
approved these changes
Aug 24, 2023
cuebit
approved these changes
Aug 24, 2023
Co-authored-by: Cue <hello@cuebit.dev>
Co-authored-by: Cue <hello@cuebit.dev>
|
Thanks a lot guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
:diroption toSDesc. This will align label and value horizontally.To control the divider, I've moved divider to
SDescItem. And added additional prop to disable it.Finally, when setting
:dirtofalse, specify:labelWidthto define the width of label area grid.