Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checkbox): allow indeterminate as the value #336

Merged
merged 6 commits into from
Aug 31, 2023
Merged

feat(checkbox): allow indeterminate as the value #336

merged 6 commits into from
Aug 31, 2023

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Aug 28, 2023

closes #335

@netlify
Copy link

netlify bot commented Aug 28, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit 0aa0e76
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/64effb60892ee400089011d7
😎 Deploy Preview https://deploy-preview-336--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (4276ebb) 84.59% compared to head (0aa0e76) 84.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
+ Coverage   84.59%   84.60%   +0.01%     
==========================================
  Files         139      139              
  Lines       11223    11231       +8     
  Branches      636      637       +1     
==========================================
+ Hits         9494     9502       +8     
  Misses       1729     1729              
Files Changed Coverage Δ
lib/components/SInputCheckbox.vue 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@netlify
Copy link

netlify bot commented Aug 28, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit 0aa0e76
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/64effb6052f4c20008d597e6
😎 Deploy Preview https://deploy-preview-336--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brc-dd brc-dd marked this pull request as draft August 28, 2023 21:29
@kiaking
Copy link
Member

kiaking commented Aug 29, 2023

I like the overall API design 👍

@brc-dd
Copy link
Member Author

brc-dd commented Aug 29, 2023

There is a bit of issue. Technically indeterminate should work same as false. I'll update the logic a bit and resolve conflicts.

@brc-dd brc-dd marked this pull request as ready for review August 29, 2023 04:48
@NozomuIkuta NozomuIkuta added the enhancement New feature or request label Aug 30, 2023
Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch! Working beautiful 👍

@kiaking kiaking merged commit a0d4aba into main Aug 31, 2023
13 checks passed
@kiaking kiaking deleted the fix/335 branch August 31, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Checkbox] Support indeterminate state
3 participants