-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(table): allow using virtual scroll with fixed column #339
Conversation
✅ Deploy Preview for sefirot-story ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for sefirot-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -21,7 +21,7 @@ export interface Table< | |||
reset?: MaybeRef<boolean | undefined> | |||
borderless?: MaybeRef<boolean> | |||
loading?: MaybeRef<boolean | undefined> | |||
virtualScroll?: MaybeRef<boolean | undefined> | |||
rowSize?: MaybeRef<number | undefined> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should include border width as well, so if the row height is 40px and there is 1px border, it should be 41px
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #339 +/- ##
==========================================
+ Coverage 84.61% 84.92% +0.31%
==========================================
Files 139 139
Lines 11217 11193 -24
Branches 637 638 +1
==========================================
+ Hits 9491 9506 +15
+ Misses 1726 1687 -39
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!!! Hold on merging this one. We only have one place where we use this at the moment so we could test it there and see it works.
So I guess only change we need to make is to use option virtualScroll
-> rowSize
👀
rowSize is optional (has default value 41), you can simply remove virtualScroll |
closes #266
TODO: