Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): allow using virtual scroll with fixed column #339

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Sep 11, 2023

closes #266

TODO:

  • revert story changes before merging

@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit 697b78d
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/64ffebc2ab123800087bee25
😎 Deploy Preview https://deploy-preview-339--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit 697b78d
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/64ffebc2bfabf6000884a7ac
😎 Deploy Preview https://deploy-preview-339--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -21,7 +21,7 @@ export interface Table<
reset?: MaybeRef<boolean | undefined>
borderless?: MaybeRef<boolean>
loading?: MaybeRef<boolean | undefined>
virtualScroll?: MaybeRef<boolean | undefined>
rowSize?: MaybeRef<number | undefined>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should include border width as well, so if the row height is 40px and there is 1px border, it should be 41px

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.31% 🎉

Comparison is base (6bfe8bb) 84.61% compared to head (697b78d) 84.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
+ Coverage   84.61%   84.92%   +0.31%     
==========================================
  Files         139      139              
  Lines       11217    11193      -24     
  Branches      637      638       +1     
==========================================
+ Hits         9491     9506      +15     
+ Misses       1726     1687      -39     
Files Changed Coverage Δ
lib/components/STable.vue 81.51% <100.00%> (+7.30%) ⬆️
lib/composables/Table.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!! Hold on merging this one. We only have one place where we use this at the moment so we could test it there and see it works.

So I guess only change we need to make is to use option virtualScroll -> rowSize 👀

@brc-dd
Copy link
Member Author

brc-dd commented Sep 11, 2023

rowSize is optional (has default value 41), you can simply remove virtualScroll

@kiaking kiaking added the enhancement New feature or request label Sep 12, 2023
@kiaking kiaking merged commit 45ce637 into main Sep 12, 2023
13 checks passed
@kiaking kiaking deleted the virtual-table branch September 12, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Table] Fixed column is not working with virtual scroll
2 participants