Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): sync scroll on filter/sort and remove hover listeners #348

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Sep 29, 2023

No description provided.

@netlify
Copy link

netlify bot commented Sep 29, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit 96caacb
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/6516dbe15bceab000874c4d1
😎 Deploy Preview https://deploy-preview-348--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brc-dd brc-dd self-assigned this Sep 29, 2023
@brc-dd brc-dd added the bug Something isn't working label Sep 29, 2023
@brc-dd brc-dd requested a review from kiaking September 29, 2023 14:15
@netlify
Copy link

netlify bot commented Sep 29, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit 96caacb
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/6516dbe19981c300082515c5
😎 Deploy Preview https://deploy-preview-348--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (206abcc) 84.84% compared to head (96caacb) 84.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
- Coverage   84.84%   84.81%   -0.03%     
==========================================
  Files         142      142              
  Lines       11374    11370       -4     
  Branches      515      515              
==========================================
- Hits         9650     9644       -6     
- Misses       1724     1726       +2     
Files Coverage Δ
lib/components/STable.vue 78.00% <26.31%> (-0.52%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brc-dd
Copy link
Member Author

brc-dd commented Sep 29, 2023

Still not sure if it fixes all the issues. Try it locally once. I'm no longer able to reproduce the issues locally though.

Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! yeah, let's try with this one and see if it gets fixed 👀

@kiaking kiaking merged commit a4a7e82 into main Oct 2, 2023
9 of 11 checks passed
@kiaking kiaking deleted the fix/table-scroll branch October 2, 2023 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants