Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): limit help and error text width #354

Merged
merged 1 commit into from
Oct 5, 2023
Merged

fix(input): limit help and error text width #354

merged 1 commit into from
Oct 5, 2023

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Oct 5, 2023

closes #353

Feel free to change it to 640px. I'd used 65ch because that's common with most of the other libraries like primer, tailwind/typography, most chrome and ms projects, etc.

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit f12cdaf
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/651e990c56325d0007fc3f94
😎 Deploy Preview https://deploy-preview-354--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit f12cdaf
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/651e990cc809180008a3b2af
😎 Deploy Preview https://deploy-preview-354--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (709e2eb) 84.77% compared to head (f12cdaf) 84.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #354   +/-   ##
=======================================
  Coverage   84.77%   84.78%           
=======================================
  Files         142      142           
  Lines       11379    11381    +2     
  Branches      516      516           
=======================================
+ Hits         9647     9649    +2     
  Misses       1732     1732           
Files Coverage Δ
lib/components/SInputBase.vue 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brc-dd brc-dd added the bug Something isn't working label Oct 5, 2023
@brc-dd brc-dd self-assigned this Oct 5, 2023
@brc-dd brc-dd requested a review from kiaking October 5, 2023 11:13
@kiaking
Copy link
Member

kiaking commented Oct 5, 2023

Wow, never knew there was ch 😳 Confirmed this also works with Japanese. Though it's not really 65ch but becomes 53ch. Probably this is after all setting width I guess.

I say we should be using this method more. Better than em 👍

@kiaking kiaking merged commit b8647e4 into main Oct 5, 2023
11 checks passed
@kiaking kiaking deleted the fix/353 branch October 5, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Input] Limit the length of help and error text
2 participants