-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(action-list): add <ActionList>
(#358)
#364
Conversation
✅ Deploy Preview for sefirot-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for sefirot-story ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #364 +/- ##
==========================================
- Coverage 82.76% 82.15% -0.61%
==========================================
Files 145 147 +2
Lines 11719 11806 +87
Branches 655 657 +2
==========================================
Hits 9699 9699
- Misses 2020 2107 +87
☔ View full report in Codecov by Sentry. |
Probably should use |
@brc-dd Ah, yeah. But that only happens when you set icon inside reactive object right...? But that could happen as soon as we pass the object inside template...? |
Yeah. I'm not sure how reactivity exactly works with arrays passed as props. But if you make them computed or something (like if you want to change that list, add/remove some item), that most likely will throw warnings. I don't think any code change is needed though. Probably can just update the example in docs. |
Make sense 👍 |
<ActionList>
#358Add
<ActionList>
. I have made the type simpler than I described on the issue. Well, this is all we need at the moment.Also, I have made few css var adjustment to match the latest color system on Figma.
--c-mute
is deprecated in favor of new--c-bg-mute-1
series.