Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(input-image): add <SInputImage> (#356) #368

Merged
merged 5 commits into from
Nov 6, 2023
Merged

feat(input-image): add <SInputImage> (#356) #368

merged 5 commits into from
Nov 6, 2023

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Nov 2, 2023

Add <SInputImage>. Pretty much followed all issue spec. Adjusted tiny wording of text.

Also, this PR contains new useImageSrcFromFile composable that can read image src from file.

  • Add docs

Screenshot 2023-11-02 at 20 48 58

@kiaking kiaking added the enhancement New feature or request label Nov 2, 2023
@kiaking kiaking self-assigned this Nov 2, 2023
Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit d8ae08d
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/654842809978e300088ab1eb
😎 Deploy Preview https://deploy-preview-368--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit d8ae08d
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/65484280c3c294000849a7dc
😎 Deploy Preview https://deploy-preview-368--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 285 lines in your changes are missing coverage. Please review.

Comparison is base (cc09f3c) 82.13% compared to head (d8ae08d) 80.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
- Coverage   82.13%   80.19%   -1.94%     
==========================================
  Files         147      149       +2     
  Lines       11792    12079     +287     
  Branches      516      517       +1     
==========================================
+ Hits         9685     9687       +2     
- Misses       2107     2392     +285     
Files Coverage Δ
lib/support/Utils.ts 91.30% <50.00%> (-8.70%) ⬇️
lib/composables/Image.ts 0.00% <0.00%> (ø)
lib/components/SInputImage.vue 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiaking kiaking marked this pull request as ready for review November 6, 2023 01:22
@kiaking kiaking requested a review from brc-dd November 6, 2023 01:22
@brc-dd
Copy link
Member

brc-dd commented Nov 6, 2023

wait a second, select image is not responsive after you remove it 👀

@kiaking kiaking merged commit 600946e into main Nov 6, 2023
9 of 11 checks passed
@kiaking kiaking deleted the input-image branch November 6, 2023 05:00
@kiaking
Copy link
Member Author

kiaking commented Nov 6, 2023

Oh sit lol

@kiaking
Copy link
Member Author

kiaking commented Nov 6, 2023

Whaat...

@brc-dd
Copy link
Member

brc-dd commented Nov 6, 2023

I'll fix it separately, some ref issue probably.

@kiaking
Copy link
Member Author

kiaking commented Nov 6, 2023

Gotcha. Thanks. Or maybe Histoire issue...?

@kiaking
Copy link
Member Author

kiaking commented Nov 6, 2023

It's working for me on Histoire 🤔

@brc-dd
Copy link
Member

brc-dd commented Nov 6, 2023

#369, I was removing and uploading the same image 😅 (I only have like one dummy image on my system 😂)

@kiaking
Copy link
Member Author

kiaking commented Nov 6, 2023

Ahhhh I see. And that I wasn't doing 😳 Nice catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add <SInputImage>
2 participants