Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): update styles to the latest (#391) #393

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Nov 17, 2023

Update various input styles to the latest.

@kiaking kiaking added the bug Something isn't working label Nov 17, 2023
@kiaking kiaking requested a review from brc-dd November 17, 2023 06:16
@kiaking kiaking self-assigned this Nov 17, 2023
Copy link

netlify bot commented Nov 17, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit d49a312
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/65570523ce35180008d73ae2
😎 Deploy Preview https://deploy-preview-393--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 17, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit d49a312
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/655705238156060008477631
😎 Deploy Preview https://deploy-preview-393--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (61cf155) 79.56% compared to head (d49a312) 79.63%.

Files Patch % Lines
lib/components/SInputSegmentsOption.vue 0.00% 13 Missing ⚠️
lib/components/SInputDropdown.vue 0.00% 9 Missing ⚠️
lib/components/SInputSegments.vue 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
+ Coverage   79.56%   79.63%   +0.07%     
==========================================
  Files         153      153              
  Lines       12302    12308       +6     
  Branches      522      522              
==========================================
+ Hits         9788     9802      +14     
+ Misses       2514     2506       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiaking kiaking merged commit a56469d into main Nov 17, 2023
10 of 11 checks passed
@kiaking kiaking deleted the 391-input-styles branch November 17, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Input] <SInputDropdown> has wrong bg color
2 participants