Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Http class #407

Merged
merged 16 commits into from
Dec 7, 2023
Merged

feat: add Http class #407

merged 16 commits into from
Dec 7, 2023

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Dec 5, 2023

closes #400

@netlify Netlify
Copy link

netlify bot commented Dec 5, 2023 •
edited

✅ Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit ad34e4e
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/65716aafcb92c300084f51e2
😎 Deploy Preview https://deploy-preview-407--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 5, 2023 •
edited

✅ Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit ad34e4e
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/65716aaf2fdbd20008aa0d8f
😎 Deploy Preview https://deploy-preview-407--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brc-dd
Copy link
Member Author

brc-dd commented Dec 5, 2023 •
edited

I've removed options for now. I don't see any project specifying anything other than query parameters. This also simplifies things if we go down the aliasing road as we won't have to worry about the type differences between axios and $fetch.

@brc-dd brc-dd marked this pull request as draft December 5, 2023 08:13
@brc-dd brc-dd self-assigned this Dec 5, 2023
@brc-dd brc-dd marked this pull request as ready for review December 5, 2023 08:51
@brc-dd
Copy link
Member Author

brc-dd commented Dec 5, 2023

tested this on nia, all operations seem to be working fine

@brc-dd brc-dd added the enhancement New feature or request label Dec 5, 2023
kiaking
kiaking reviewed Dec 6, 2023
View reviewed changes
lib/composables/Http.ts Outdated Show resolved Hide resolved
kiaking
kiaking reviewed Dec 6, 2023
View reviewed changes
lib/composables/Http.ts Outdated Show resolved Hide resolved
@brc-dd
Copy link
Member Author

brc-dd commented Dec 7, 2023

updated

kiaking
kiaking reviewed Dec 7, 2023
View reviewed changes
lib/http/Http.ts Outdated Show resolved Hide resolved
kiaking
kiaking reviewed Dec 7, 2023
View reviewed changes
Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added doc! And made one comment 🙏 Maybe we should export FetchOptions? 🤔

Other than that, LGTM 👍

brc-dd
brc-dd commented Dec 7, 2023
View reviewed changes
docs/network-requests/http.md Outdated Show resolved Hide resolved
@kiaking @brc-dd
Update docs/network-requests/http.md
ad34e4e 
Co-authored-by: Divyansh Singh <40380293+brc-dd@users.noreply.github.com>
@kiaking kiaking merged commit 93a4508 into main Dec 7, 2023
9 checks passed
@kiaking kiaking deleted the http branch December 7, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiaking kiaking kiaking left review comments

Assignees

@brc-dd brc-dd

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Http] Add Http module
2 participants
@brc-dd @kiaking