Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table): accept ref on column show option #418

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Dec 19, 2023

Currently, if we use computed on columns, the types get fucked up. Usually, we wanna use reactive value for show option, so for now, enabling ref value on show to bypass the issue.

const table = useTable({
  columns: {
    name: {
      // Now we can do this.
      show: () => shouldShow.value
    }
  }
})

@kiaking kiaking self-assigned this Dec 19, 2023
Copy link

netlify bot commented Dec 19, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit cd2d727
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/65815c9b88ee04000838345d
😎 Deploy Preview https://deploy-preview-418--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 19, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit cd2d727
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/65815c9b0f0a5f000837c863
😎 Deploy Preview https://deploy-preview-418--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kiaking kiaking added the enhancement New feature or request label Dec 19, 2023
@kiaking kiaking merged commit 1912121 into main Dec 19, 2023
9 checks passed
@kiaking kiaking deleted the table-accept-ref-on-show branch December 19, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants