Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(action-menu): add <SActionMenu> #426

Merged
merged 5 commits into from
Dec 27, 2023
Merged

feat(action-menu): add <SActionMenu> #426

merged 5 commits into from
Dec 27, 2023

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Dec 25, 2023

Add action menu component, inspired by GitHub Primer: Action Menu.

It also includes change where DropdownSectionMenu is now directly integrated and using <SActionList> to display the menu.

Adjusting the key differences as well, where action list uses text, dropdown is using label. label is deprecated 👀

<SActionMenu
  label="Open menu"
  :options="dropdownOptions"
/>
Screenshot 2023-12-25 at 13 49 06

@kiaking kiaking added the enhancement New feature or request label Dec 25, 2023
@kiaking kiaking requested a review from brc-dd December 25, 2023 04:59
@kiaking kiaking self-assigned this Dec 25, 2023
Copy link

netlify bot commented Dec 25, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit 1f969a0
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/658a2e302298f50008e8f7af
😎 Deploy Preview https://deploy-preview-426--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 25, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit 1f969a0
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/658a2e3020ff820008f5d463
😎 Deploy Preview https://deploy-preview-426--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brc-dd
Copy link
Member

brc-dd commented Dec 25, 2023

table dropdowns look broken

image

@kiaking
Copy link
Member Author

kiaking commented Dec 25, 2023

@brc-dd
Thanks for the catch...! I wasn't handling the deprecated label option correctly... 😢 Fixed!

Also, added <SControlActionMenu>.

@kiaking kiaking merged commit a6a7baf into main Dec 27, 2023
9 checks passed
@kiaking kiaking deleted the action-menu branch December 27, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants