New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(validation): add Japanese error messages #437

Merged

kiaking merged 10 commits into main from feat/l10n-validation

Jan 15, 2024

Contributor

NozomuIkuta commented Jan 11, 2024

No related issues.


          feat(validation): add Japanese error messages

c105902

NozomuIkuta self-assigned this

netlify bot commented Jan 11, 2024 •

edited

✅ Deploy Preview for sefirot-story ready!

Name	Link
🔨 Latest commit	`854d318`
🔍 Latest deploy log	https://app.netlify.com/sites/sefirot-story/deploys/65a49f6e077ecd000829dea7
😎 Deploy Preview	https://deploy-preview-437--sefirot-story.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Jan 11, 2024 •

edited

✅ Deploy Preview for sefirot-docs ready!

Name	Link
🔨 Latest commit	`854d318`
🔍 Latest deploy log	https://app.netlify.com/sites/sefirot-docs/deploys/65a49f6ea0450a000859703b
😎 Deploy Preview	https://deploy-preview-437--sefirot-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

NozomuIkuta added 2 commits

January 11, 2024 17:14


          fix: fix message

5d54d33


          fix: fix lint

9947deb

brc-dd reviewed

View reviewed changes

lib/validation/validators/url.ts Show resolved Hide resolved


          chore: simplify url validator

6699f3d

NozomuIkuta commented

View reviewed changes

lib/validation/validators/requiredIf.ts Show resolved Hide resolved

NozomuIkuta commented

View reviewed changes

lib/validation/rules/checked.ts Outdated Show resolved Hide resolved

NozomuIkuta commented

View reviewed changes

lib/validation/rules/fileExtension.ts Outdated Show resolved Hide resolved

NozomuIkuta commented

View reviewed changes

lib/validation/rules/hms.ts Outdated Show resolved Hide resolved

NozomuIkuta commented

View reviewed changes

lib/validation/rules/maxFileSize.ts Outdated Show resolved Hide resolved

NozomuIkuta commented

View reviewed changes

lib/validation/rules/maxTotalFileSize.ts Outdated Show resolved Hide resolved

NozomuIkuta commented

View reviewed changes

lib/validation/rules/month.ts Outdated Show resolved Hide resolved

NozomuIkuta commented

View reviewed changes

lib/validation/rules/requiredYmd.ts Outdated Show resolved Hide resolved

NozomuIkuta commented

View reviewed changes

lib/validation/rules/rule.ts Outdated Show resolved Hide resolved

NozomuIkuta commented

View reviewed changes

lib/validation/rules/ymd.ts Outdated Show resolved Hide resolved

NozomuIkuta commented

View reviewed changes

lib/validation/validators/maxLength.ts Outdated Show resolved Hide resolved

NozomuIkuta commented

View reviewed changes

lib/validation/validators/maxValue.ts Outdated Show resolved Hide resolved

NozomuIkuta commented

View reviewed changes

lib/validation/validators/minLength.ts Outdated Show resolved Hide resolved

NozomuIkuta commented

View reviewed changes

lib/validation/validators/minValue.ts Outdated Show resolved Hide resolved


          Revert "chore: simplify url validator"

424d11f

This reverts commit 6699f3d.

kiaking reviewed

View reviewed changes

lib/validation/rules/decimalOrHyphen.ts Outdated Show resolved Hide resolved

kiaking reviewed

View reviewed changes

lib/validation/rules/email.ts Outdated Show resolved Hide resolved

kiaking reviewed

View reviewed changes

lib/validation/rules/url.ts Outdated Show resolved Hide resolved

NozomuIkuta added 2 commits

January 12, 2024 15:14


          fix: fix error messages

e5c53aa


          fix: remove unneeded code

5c20e70

NozomuIkuta mentioned this pull request

[Validation] Make value argument of validators functions of type unknown #438

Closed


          fix: fix unit tests

b253c9b

NozomuIkuta commented

View reviewed changes

lib/validation/validators/decimal.ts Show resolved Hide resolved

NozomuIkuta commented

View reviewed changes

lib/validation/validators/email.ts Show resolved Hide resolved

NozomuIkuta commented

View reviewed changes

lib/validation/validators/url.ts Show resolved Hide resolved


          Merge remote-tracking branch 'origin/main' into feat/l10n-validation

05475ca

NozomuIkuta marked this pull request as ready for review

January 15, 2024 02:06

NozomuIkuta requested review from brc-dd and kiaking

January 15, 2024 02:06

kiaking requested changes

View reviewed changes

Member

kiaking left a comment

@NozomuIkuta
There are still helpers.req(value) used in validators 👀


          fix: remove unneeded code

854d318

Contributor Author

NozomuIkuta commented Jan 15, 2024

@NozomuIkuta
There are still helpers.req(value) used in validators 👀

Fixed: 854d318

NozomuIkuta requested a review from kiaking

January 15, 2024 03:04

kiaking approved these changes

View reviewed changes

Member

kiaking left a comment

👍

kiaking merged commit 4436557 into main

9 checks passed

kiaking deleted the feat/l10n-validation branch

January 15, 2024 03:06

NozomuIkuta mentioned this pull request

fix(validation): fix rules and unit tests #443

Merged

5 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment