Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: many bugs with useUrlQuerySync #467

Merged
merged 5 commits into from
Feb 13, 2024
Merged

fix: many bugs with useUrlQuerySync #467

merged 5 commits into from
Feb 13, 2024

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Feb 12, 2024

rewrote it 🫠

The caveats are safe to ignore. I'll fix them later if needed.

@brc-dd brc-dd self-assigned this Feb 12, 2024
@brc-dd brc-dd requested a review from kiaking February 12, 2024 20:27
Copy link

netlify bot commented Feb 12, 2024

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit cafd600
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/65cab7db217d9000082a4157
😎 Deploy Preview https://deploy-preview-467--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 12, 2024

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit cafd600
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/65cab7db8e7e970008285b81
😎 Deploy Preview https://deploy-preview-467--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved comments to simply be function comment 👍 Other than that, I trust you on this 😳 Feel free to merge when you're ready!

@brc-dd brc-dd merged commit 50e34e8 into main Feb 13, 2024
9 checks passed
@brc-dd brc-dd deleted the url-sync-rewrite branch February 13, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants