Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(input-textarea): add preview functionality #471

Merged
merged 4 commits into from
Feb 19, 2024
Merged

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Feb 14, 2024

https://deploy-preview-471--sefirot-story.netlify.app/story/stories-components-sinputtextarea-01-playground-story-vue?variantId=_default

We can probably leave .prose ... styles to be implemented at consumer-side because they largely will be common with the actual post rendering.

@brc-dd brc-dd requested a review from kiaking February 14, 2024 04:30
Copy link

netlify bot commented Feb 14, 2024

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit 61add40
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/65d32173f947150008ecb669
😎 Deploy Preview https://deploy-preview-471--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 14, 2024

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit 61add40
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/65d32173e20ade00082d2513
😎 Deploy Preview https://deploy-preview-471--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kiaking
Copy link
Member

kiaking commented Feb 19, 2024

Did deign on Figma. Thinking to go with this. In the future, we may add action bar too if we want (like GitHub has 👀

Screenshot 2024-02-19 at 17 04 27

@kiaking
Copy link
Member

kiaking commented Feb 19, 2024

@brc-dd
Updated the style!

  • Refactored css (put base stuff on top, custom at bottom)
  • Adjusted fill option handling.

We can probably leave .prose ... styles to be implemented at consumer-side because they largely will be common with the actual post rendering.

And I agree on this 👍

Screenshot 2024-02-19 at 18 03 23

@kiaking
Copy link
Member

kiaking commented Feb 19, 2024

Feel free to merge when you're ready. Nothing from my side anymore 🙌

@kiaking
Copy link
Member

kiaking commented Feb 19, 2024

Oops wait, forgot about error state. Gonna fix it.

@kiaking
Copy link
Member

kiaking commented Feb 19, 2024

OK, done.

@brc-dd
Copy link
Member Author

brc-dd commented Feb 19, 2024

LGTM

image

@brc-dd brc-dd merged commit 1510d12 into main Feb 19, 2024
9 checks passed
@brc-dd brc-dd deleted the textarea-preview branch February 19, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants