feat(avatar): add more size option #475
Merged
+29
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more size option to
<SAvatar>
.jumbo
-48px
big. Adding this to be more consistent with<SButton>
sizing.fill
- Custom size that fills the parent container. When we want avatar bigger than 48px, use this.One issue with
fill
option is that it's hard to setfont-size
for name initial when the user don't have avatar image.@brc-dd
Do you know any tricks to like set font size dynamically based on parent container? If not, I think we can stick to
font-size: 20px
I've set. We should only usefill
when we need big avatar and that's quite rare case so 👀